[fix] Follow correct versioning pattern for vmm_register/instance_ensure_registered#9407
Merged
jgallagher merged 4 commits intomainfrom Nov 18, 2025
Merged
Conversation
…ensure_registered` My previous multicast-support integration PR flipped outdated/updated versioning. This work fixes that, following proper versioning design. For consistency, we now include prefix version naming conventions (i.e. `v1_`). We also place the v1 versions of `InstanceEnsureBody` and `InstanceSledLocalConfig` in "sled-agent/types/src/v1.rs" instead of in the API directory.
jgallagher
reviewed
Nov 17, 2025
Contributor
jgallagher
left a comment
jgallagher
left a comment
There was a problem hiding this comment.
Thanks for picking this up so quickly!
bnaecker
reviewed
Nov 17, 2025
We move the v6 (pre-multicast version) of code back to `sled-agent/api/src`, but implement the default conversion / shim at the endpoint.
jmpesp
requested changes
Nov 17, 2025
jmpesp
approved these changes
Nov 17, 2025
Contributor
jmpesp
left a comment
jmpesp
left a comment
There was a problem hiding this comment.
Looks good, one thing: I can't comment on rows not affected by the diff, but make sure that the docstring change for InstanceEnsureBody doesn't change with this shuffling around. Otherwise 🚢
This was referenced Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My previous multicast-support integration PR flipped outdated/updated versioning. This work fixes that, following proper versioning design. For consistency, we now include prefix version naming conventions (i.e.,
v6_).